From 9a0ec818279e2422a162e37c367f334bfe757a4d Mon Sep 17 00:00:00 2001 From: Cyrille Tuzi Date: Thu, 2 Nov 2017 09:17:07 +0100 Subject: [PATCH 1/4] fix(lint): update lint tools for Angular 5 codelyzer 4 is required for Angular 5. --- packages/schematics/angular/application/files/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/schematics/angular/application/files/package.json b/packages/schematics/angular/application/files/package.json index 06975fcbbf..842a953d95 100644 --- a/packages/schematics/angular/application/files/package.json +++ b/packages/schematics/angular/application/files/package.json @@ -32,7 +32,7 @@ "@types/jasmine": "~2.5.53", "@types/jasminewd2": "~2.0.2", "@types/node": "~6.0.60", - "codelyzer": "~3.2.0", + "codelyzer": "^4.0.0", "jasmine-core": "~2.6.2", "jasmine-spec-reporter": "~4.1.0", "karma": "~1.7.0", @@ -43,7 +43,7 @@ "karma-jasmine-html-reporter": "^0.2.2", "protractor": "~5.1.2", "ts-node": "~3.2.0", - "tslint": "~5.7.0",<% } %> + "tslint": "^5.8.0",<% } %> "typescript": "~2.4.2" } } From 3817aa250631b9e5c81b94910cb1aafe75d00d47 Mon Sep 17 00:00:00 2001 From: Cyrille Tuzi Date: Thu, 2 Nov 2017 09:20:54 +0100 Subject: [PATCH 2/4] fix(lint): update lint rules for codelyzer 4.0 and tslint 5.8 --- packages/schematics/angular/application/files/tslint.json | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/schematics/angular/application/files/tslint.json b/packages/schematics/angular/application/files/tslint.json index d9af7070a6..880fdca882 100644 --- a/packages/schematics/angular/application/files/tslint.json +++ b/packages/schematics/angular/application/files/tslint.json @@ -104,7 +104,6 @@ "variable-declaration": "nospace" } ], - "typeof-compare": true, "unified-signatures": true, "variable-name": false, "whitespace": [ @@ -135,7 +134,6 @@ "use-life-cycle-interface": true, "use-pipe-transform-interface": true, "component-class-suffix": true, - "directive-class-suffix": true, - "invoke-injectable": true + "directive-class-suffix": true } } From da53347f9ff0805dc72bde72fb30c40c20e11387 Mon Sep 17 00:00:00 2001 From: Cyrille Tuzi Date: Tue, 14 Nov 2017 21:40:16 +0100 Subject: [PATCH 3/4] fix(@schematics/angular): update codelyzer to 4.0.1 --- packages/schematics/angular/application/files/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/schematics/angular/application/files/package.json b/packages/schematics/angular/application/files/package.json index 842a953d95..5e0673a602 100644 --- a/packages/schematics/angular/application/files/package.json +++ b/packages/schematics/angular/application/files/package.json @@ -32,7 +32,7 @@ "@types/jasmine": "~2.5.53", "@types/jasminewd2": "~2.0.2", "@types/node": "~6.0.60", - "codelyzer": "^4.0.0", + "codelyzer": "^4.0.1", "jasmine-core": "~2.6.2", "jasmine-spec-reporter": "~4.1.0", "karma": "~1.7.0", From fd9ff3c6cc8b5736b485ce36831127c0ed2b8f89 Mon Sep 17 00:00:00 2001 From: Cyrille Tuzi Date: Thu, 2 Nov 2017 09:17:07 +0100 Subject: [PATCH 4/4] fix(@schematics/angular): update lint tools for Angular 5 codelyzer 4 is required for Angular 5. Some rules are removed as they are deprecated. tslint is also updated to 5.8. --- packages/schematics/angular/application/files/package.json | 4 ++-- packages/schematics/angular/application/files/tslint.json | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/schematics/angular/application/files/package.json b/packages/schematics/angular/application/files/package.json index 06975fcbbf..5e0673a602 100644 --- a/packages/schematics/angular/application/files/package.json +++ b/packages/schematics/angular/application/files/package.json @@ -32,7 +32,7 @@ "@types/jasmine": "~2.5.53", "@types/jasminewd2": "~2.0.2", "@types/node": "~6.0.60", - "codelyzer": "~3.2.0", + "codelyzer": "^4.0.1", "jasmine-core": "~2.6.2", "jasmine-spec-reporter": "~4.1.0", "karma": "~1.7.0", @@ -43,7 +43,7 @@ "karma-jasmine-html-reporter": "^0.2.2", "protractor": "~5.1.2", "ts-node": "~3.2.0", - "tslint": "~5.7.0",<% } %> + "tslint": "^5.8.0",<% } %> "typescript": "~2.4.2" } } diff --git a/packages/schematics/angular/application/files/tslint.json b/packages/schematics/angular/application/files/tslint.json index d9af7070a6..880fdca882 100644 --- a/packages/schematics/angular/application/files/tslint.json +++ b/packages/schematics/angular/application/files/tslint.json @@ -104,7 +104,6 @@ "variable-declaration": "nospace" } ], - "typeof-compare": true, "unified-signatures": true, "variable-name": false, "whitespace": [ @@ -135,7 +134,6 @@ "use-life-cycle-interface": true, "use-pipe-transform-interface": true, "component-class-suffix": true, - "directive-class-suffix": true, - "invoke-injectable": true + "directive-class-suffix": true } }