-
Notifications
You must be signed in to change notification settings - Fork 12k
add support for external template/styles in webpack branch #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I got it working in 5 minutes but ran into a problem with importing in different contexts (known problem when working in Node with Angular 2 because Angular's di relies on references. The other problem is Reflect which has the same problem). I just need to isolate the prerendering in a separate process |
I like that idea, it will make mobile much less special-case-y. I should mention that at the moment we're using a built-in version of angular/universal#464 instead of importing |
it shouldn't be too hard to also prerender other pages with folders using the router config. I got it working if |
@gdi2290 did you manage to get it working? If you point me in the right direction I can maybe pick it up. |
Closing this as fixed already. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I tried removing the
isMobile
special case fromapp.component.ts
and use the standardtemplateUrl
andstyleUrls
to see if the new webpack magic would automatically fix the issues with loading external templates, but it still fails. I walked through with @gdi2290 and he proposes that we make the webpack app shell plugin (addon/ng2/utilities/prerender-webpack-plugin.ts
) run against webpack-already-processed files/bundles, which will have already inlined the template and styles via theangular2-template-loader
.Patrick says he can have it done in 5 minutes from now.
The text was updated successfully, but these errors were encountered: