Skip to content

[MNT] Add pre-commit hook for mypy #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MatthewMiddlehurst opened this issue Jul 29, 2024 · 0 comments · Fixed by #2092
Closed

[MNT] Add pre-commit hook for mypy #1856

MatthewMiddlehurst opened this issue Jul 29, 2024 · 0 comments · Fixed by #2092
Labels
maintenance Continuous integration, unit testing & package distribution

Comments

@MatthewMiddlehurst
Copy link
Member

Describe the issue

From July 26 2024 meeting.

There are a few type hint errors, and no method to easily discover these. We should include some automated type checking for type hints in pre-commit.

Suggest a potential alternative/fix

The first package that comes to mind for this is mypy, but it does not necessarily have to be this.

i.e.

- repo: https://github.com/pre-commit/mirrors-mypy
   rev: v1.0.1
   hooks:
     - id: mypy
       files: aeon/
       additional_dependencies: [ pytest ]

This should be set up to only be run manually for now, however. There are a lot of breakages that we do not want to do at once.

Additional context

No response

@MatthewMiddlehurst MatthewMiddlehurst added the maintenance Continuous integration, unit testing & package distribution label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant