Skip to content

Update CardView grid navigation #2605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LFDanLu opened this issue Nov 29, 2021 · 0 comments · Fixed by #2737
Closed

Update CardView grid navigation #2605

LFDanLu opened this issue Nov 29, 2021 · 0 comments · Fixed by #2737
Assignees

Comments

@LFDanLu
Copy link
Member

LFDanLu commented Nov 29, 2021

🙋 Feature Request

#2328 doesn't quite fit for CardView so we'll need to settle on a different keyboard navigation strategy. For now we will discourage having focusable items within a Card in favor of a external action bar so do the following:

  • remove the action menu from the CardView stories
  • make the checkbox in the Card non-keyboard navigable

This maybe enough to have a satisfactory keyboard navigation experience for CardView for now, make sure to test

🤔 Expected Behavior

Arrow key navigation should move focus between Cards in a CardView

😯 Current Behavior

Right arrow key navigation currently moves focus within a Card in CardView

💁 Possible Solution

See above

🧢 Your Company/Team

RSP

🎁 Tracking Ticket (optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant