Merge pull request #151 from edgar-bonet/signed-compare

drak7 · web-flow · commit a40bfbc148f2 · 2020-04-21T10:38:22.000-04:00
Fix signed/unsigned compare warnings
diff --git a/RTClib.cpp b/RTClib.cpp
@@ -194,7 +194,7 @@ DateTime::DateTime(uint32_t t) {
   uint8_t leap;
   for (yOff = 0;; ++yOff) {
     leap = yOff % 4 == 0;
-    if (days < 365 + leap)
+    if (days < 365U + leap)
       break;
     days -= 365 + leap;
   }
@@ -448,7 +448,7 @@ char *DateTime::toString(char *buffer) {
     }
   }
 
-  for (int i = 0; i < strlen(buffer) - 1; i++) {
+  for (size_t i = 0; i < strlen(buffer) - 1; i++) {
     if (buffer[i] == 'h' && buffer[i + 1] == 'h') {
       if (!apTag) { // 24 Hour Mode
         buffer[i] = '0' + hh / 10;

Original file line number	Diff line number	Diff line change
`@@ -194,7 +194,7 @@ DateTime::DateTime(uint32_t t) {`
`194`	`194`	`uint8_t leap;`
`195`	`195`	`for (yOff = 0;; ++yOff) {`
`196`	`196`	`leap = yOff % 4 == 0;`
`197`		`- if (days < 365 + leap)`
	`197`	`+ if (days < 365U + leap)`
`198`	`198`	`break;`
`199`	`199`	`days -= 365 + leap;`
`200`	`200`	`}`
`@@ -448,7 +448,7 @@ char DateTime::toString(char buffer) {`
`448`	`448`	`}`
`449`	`449`	`}`
`450`	`450`
`451`		`- for (int i = 0; i < strlen(buffer) - 1; i++) {`
	`451`	`+ for (size_t i = 0; i < strlen(buffer) - 1; i++) {`
`452`	`452`	`if (buffer[i] == 'h' && buffer[i + 1] == 'h') {`
`453`	`453`	`if (!apTag) { // 24 Hour Mode`
`454`	`454`	`buffer[i] = '0' + hh / 10;`