Skip to content

[2.0] classic_address isn't typed properly #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mvadari opened this issue Jul 6, 2023 · 2 comments
Closed

[2.0] classic_address isn't typed properly #616

mvadari opened this issue Jul 6, 2023 · 2 comments

Comments

@mvadari
Copy link
Collaborator

mvadari commented Jul 6, 2023

image

It looks like property aliases aren't supported in mypy right now: python/mypy#6700

The best solution is likely to just copy-paste the address code, with a TODO for when mypy has resolved the issue.
@JST5000
Copy link
Contributor

JST5000 commented Jul 6, 2023 •
edited
Loading

For people encountering this issue before the next release, if you change from .classic_address to .address the issue goes away.

@JST5000 JST5000 mentioned this issue Jul 6, 2023
Merged
1 task
@ckniffen
Copy link
Collaborator

Closed by #617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ckniffen @mvadari @JST5000