Bump rust-analyzer dependency to 2024-08-12

Summary:
The rust-analyzer dependency is currently 2024-07-29.  It turns out that a few days after that an important performance improvement landed, which does parallel loading for file in VFS. This has a significant impact on initial startup time.

This  diff does the bare minimum to move to the first subsequent release that had this feature, from [2024-08-12](https://github.com/rust-lang/rust-analyzer/releases/tag/2024-08-12).

The key change is [this one](rust-lang/rust-analyzer#17771) "load VFS config changes in parallel."

Reviewed By: jcpetruzza, michalmuskala

Differential Revision: D72724277

fbshipit-source-id: eac8f371acfa548df0c51fcf2c6c49fe5417f36f

Author: alanz

Cargo.lock

@@ -56,7 +56,7 @@ jemalloc-ctl = { version = "0.5.0", package = "tikv-jemalloc-ctl" }
 jemallocator = { version = "0.5.4", package = "tikv-jemallocator" }
 jod-thread = "0.1.2"
 krates = "0.12.6"
-la-arena = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-07-29" }
+la-arena = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-08-12" }
 lazy_static = "1.5.0"
 log = "0.4.22"
 lsp-server = "0.7.6"
@@ -67,11 +67,11 @@ num-derive = "0.4.2"
 num-traits = "0.2.19"
 once_cell = "1.19.0"
 parking_lot = "0.12.3"
-paths = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-07-29" }
+paths = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-08-12" }
 proc-macro2 = "1.0.86"
 profile = { features = [
     "jemalloc",
-], git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-07-29" }
+], git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-08-12" }
 quote = "1.0.36"
 range-set = "0.0.10"
 rayon = "1.10.0"
@@ -88,13 +88,13 @@ serde_path_to_error = "0.1.16"
 serde_with = "1.14.0"
 smallvec = { version = "1.13.2", features = ["const_new", "union", "const_generics"] }
 smol_str = "0.1.24"
-stdx = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-07-29" }
+stdx = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-08-12" }
 strsim = { version = "0.10.0" }
 strum = "0.25.0"
 strum_macros = "0.25.3"
 tempfile = "3.12.0"
 test-case = "2.2.2"
-text-edit = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-07-29" }
+text-edit = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-08-12" }
 text-size = "1.1.1"
 thiserror = "1.0"
 tracing = "0.1.40"
@@ -106,7 +106,7 @@ tree-sitter = "0.23.2"
 tree-sitter-erlang = "0.14.0" # @oss-only
 url = "2.5.4"
 ustr = { version = "1.1.0", features = ["serde"] }
-vfs = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-07-29" }
-vfs-notify = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-07-29" }
+vfs = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-08-12" }
+vfs-notify = { git = "https://github.com/rust-lang/rust-analyzer", rev = "2024-08-12" }
 walkdir = "2.5.0"
 xshell = "0.2.6"

Cargo.toml

@@ -38,6 +38,7 @@ use elp_project_model::IncludeParentDirs;
 use elp_project_model::Project;
 use elp_project_model::ProjectManifest;
 use fxhash::FxHashMap;
+use vfs::loader::LoadingProgress;
 use vfs::VfsPath;
 
 use crate::build::types::LoadResult;
@@ -158,11 +159,14 @@ fn load_database(
                 n_done, n_total, ..
             } => {
                 pb.set_length(n_total as u64);
-                if let Some(n_done) = n_done {
-                    pb.set_position(n_done as u64);
-                }
-                if n_done == Some(n_total) {
-                    break;
+                match n_done {
+                    LoadingProgress::Started => {}
+                    LoadingProgress::Progress(n_done) => {
+                        pb.set_position(n_done as u64);
+                    }
+                    LoadingProgress::Finished => {
+                        break;
+                    }
                 }
             }
             loader::Message::Loaded { files } | loader::Message::Changed { files } => {

crates/elp/src/build/load.rs

@@ -85,6 +85,7 @@ use parking_lot::Mutex;
 use parking_lot::RwLock;
 use parking_lot::RwLockWriteGuard;
 use serde::Serialize;
+use vfs::loader::LoadingProgress;
 use vfs::Change;
 
 use self::dispatch::RequestDispatcher;
@@ -885,11 +886,10 @@ impl Server {
         result && path_ref.is_file()
     }
 
-    fn on_loader_progress(&mut self, n_total: usize, n_done: Option<usize>, config_version: u32) {
+    fn on_loader_progress(&mut self, n_total: usize, n_done: LoadingProgress, config_version: u32) {
         // report progress
         always!(config_version <= self.vfs_config_version);
-        // n_done is `None` for a response to a config change
-        if let Some(n_done) = n_done {
+        if let LoadingProgress::Progress(n_done) = n_done {
             if n_done == 0 && n_total != 0 {
                 let pb = self
                     .progress

crates/elp/src/server.rs

@@ -7,7 +7,6 @@
  * of this source tree.
  */
 
-use std::convert::TryFrom;
 use std::env;
 use std::fs;
 
@@ -213,7 +212,7 @@ fn root_path(params: &InitializeParams) -> Result<AbsPathBuf> {
         .root_uri
         .as_ref()
         .and_then(|uri| uri.to_file_path().ok())
-        .and_then(|path| AbsPathBuf::try_from(path).ok())
+        .map(|path| AbsPathBuf::assert_utf8(path))
     {
         Some(path) => Ok(path),
         None => {