Skip to content

Commit 63b7a24

Browse files
committed
In JavaScriptEngineSwitcher.ChakraCore fixed a error #34 “Finalazier thread is blocked because of JavaScriptEngineSwitcher.ChakraCore.ChakraCoreJsEngine”
1 parent 9cb09a4 commit 63b7a24

File tree

3 files changed

+9
-13
lines changed

3 files changed

+9
-13
lines changed

NuGet/JavaScriptEngineSwitcher.ChakraCore/JavaScriptEngineSwitcher.ChakraCore.nuspec

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ This package does not contain the native implementations of ChakraCore. Therefor
2020
* JavaScriptEngineSwitcher.ChakraCore.Native.linux-x64
2121
* JavaScriptEngineSwitcher.ChakraCore.Native.osx-x64</description>
2222
<summary>JavaScriptEngineSwitcher.ChakraCore contains adapter `ChakraCoreJsEngine` (wrapper for the ChakraCore).</summary>
23-
<releaseNotes>1. ChakraCore was updated to version 1.8.4;
24-
2. JavaScriptEngineSwitcher.ChakraCore.Native.win8-arm package has been replaced by the JavaScriptEngineSwitcher.ChakraCore.Native.win-arm package.</releaseNotes>
23+
<releaseNotes>Fixed a error #34 “Finalazier thread is blocked because of JavaScriptEngineSwitcher.ChakraCore.ChakraCoreJsEngine”.</releaseNotes>
2524
<copyright>Copyright (c) 2013-2018 Andrey Taritsyn - http://www.taritsyn.ru</copyright>
2625
<language>en-US</language>
2726
<tags>JavaScriptEngineSwitcher JavaScript ECMAScript ChakraCore</tags>

NuGet/JavaScriptEngineSwitcher.ChakraCore/readme.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,8 @@
3030
=============
3131
RELEASE NOTES
3232
=============
33-
1. ChakraCore was updated to version 1.8.4;
34-
2. JavaScriptEngineSwitcher.ChakraCore.Native.win8-arm package has been replaced
35-
by the JavaScriptEngineSwitcher.ChakraCore.Native.win-arm package.
33+
Fixed a error #34 “Finalazier thread is blocked because of
34+
JavaScriptEngineSwitcher.ChakraCore.ChakraCoreJsEngine”.
3635

3736
=============
3837
DOCUMENTATION

src/JavaScriptEngineSwitcher.ChakraCore/ChakraCoreJsEngine.cs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1334,17 +1334,15 @@ private void Dispose(bool disposing)
13341334
{
13351335
if (_dispatcher != null)
13361336
{
1337-
_dispatcher.Invoke(() =>
1338-
{
1339-
if (_jsContext.IsValid)
1340-
{
1341-
_jsContext.Release();
1342-
}
1343-
_jsRuntime.Dispose();
1344-
});
13451337
_dispatcher.Dispose();
13461338
}
13471339

1340+
if (_jsContext.IsValid)
1341+
{
1342+
_jsContext.Release();
1343+
}
1344+
_jsRuntime.Dispose();
1345+
13481346
if (disposing)
13491347
{
13501348
if (_externalObjects != null)

0 commit comments

Comments
 (0)