Skip to content

CombineLatest incorrect? #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
akarnokd opened this issue Dec 12, 2013 · 1 comment
Closed

CombineLatest incorrect? #613

akarnokd opened this issue Dec 12, 2013 · 1 comment

Comments

@akarnokd
Copy link
Member

I've looked into the OperationCombineLatest implementation and I think it is incorrectly implemented:

  • Doesn't seem to allow multiple observers on the same combiner as the Aggregator is per source observable and not per subscribing observer.
  • I think the contract requires that no onNext value is lost on any of the source observers yet since they are not synchronized with each other, a source observer might overwrite its current value while the collection is running in Aggregator.next().

Thoughts?

Edit: I was wrong with case 2; if one is faster than the others, that is not a problem.

@benjchristensen
Copy link
Member

Fixed in #708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants