-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Completable operator review #3580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note that there is already a discussion in #3570 regarding the instance method |
If we rename |
Also the |
The problem with this rename is that
Okay.
I've omitted BlockingCompletable because there are only 2 x 2 reasonable blocking operations: |
Any more on this or can it be closed? |
Before we release
rx.Completable
into the wild (that is before we release v1.1.1) I'd like to open up a thread for discussion regardingCompletable
's instance methods, static methods, as well as any conversion methods to/from Observable and Single. Please feel free to review and comment here with any concerns. Any that need to be addressed should result in either a PR or another issue to track or discuss.The text was updated successfully, but these errors were encountered: