Skip to content

use class for config generation #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fxck opened this issue Aug 27, 2016 · 6 comments
Closed

use class for config generation #910

fxck opened this issue Aug 27, 2016 · 6 comments

Comments

@fxck fxck changed the title use es6 class style for configs use class for config generation Aug 27, 2016
@katallaxie
Copy link
Contributor

See v6

@fxck
Copy link
Author

fxck commented Oct 30, 2016

What's missing @katallaxie ?

@fxck
Copy link
Author

fxck commented Oct 31, 2016

There's a problem with those DLLs @katallaxie, when you have a vendor script that extends something like rxjs Subject(like @ngrx/store), and you don't put it inside the "rxjs" dll array, none of the added operators are gonna work on it. Perhaps it's just a naming / documentation problem though.

@katallaxie
Copy link
Contributor

@fxck that's a feature 😄 . yep, but that is how it works, because all deps are then linked

@fxck
Copy link
Author

fxck commented Oct 31, 2016

Yeah, but given that it's called

// RxJS
export function rxjs(env?: any) { }

I automatically assumed it's rxjs operators only, but in fact, it's for every lib that's using rxjs :)

@katallaxie
Copy link
Contributor

@fxck you could simply move everything to vendor, if you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants