Skip to content

Final content review #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
gkwan-ibm opened this issue Nov 23, 2022 · 3 comments
Closed
3 tasks done

Final content review #16

gkwan-ibm opened this issue Nov 23, 2022 · 3 comments
Assignees

Comments

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Nov 23, 2022

  • double check that the gRPC only support EE8 (using javax.* packages, and not jakarta.*)
  • change the System.out code to use JUL
  • rename the methods in SystemService.java file
    • getPropertiesServer() to getServerStreamingProperties()
    • getPropertiesClient() to getClientStreamingProperties()
    • getPropertiesBidirect() to getBidirectProperties()
    • update the README accordingly
@shin19991207
Copy link
Contributor

Addressed in #17

@gkwan-ibm
Copy link
Member Author

gkwan-ibm commented Nov 25, 2022

mvn -pl systemproto install generates class target/generated-sources/protobuf/grpc-java/io/openliberty/guides/systemproto/SystemServiceGrpc.java that contains javax.annotation.Generated. It is EE8 namespace.

Same issue in grpc/grpc-java#9153, and it may be related to grpc/grpc-java#9179

@hutchig
Copy link

hutchig commented Dec 1, 2022

The solution for javax.annotation.Generated is to post process the generated code with https://openliberty.io/blog/2021/03/17/eclipse-transformer.html as the OpenLiberty FAT bucket does for EE9+ and it will be good for the guide to mention this @gkwan-ibm  ....Actually having reviewed how the FAT tests do this - it would not be easy for users to cut'n'paste the way we do it there, so just a reference to https://openliberty.io/blog/2021/03/17/eclipse-transformer.html is probably best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants