Skip to content

tomlFormat.generate doesn't chomp tab indentation #8874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kreyren opened this issue Aug 27, 2023 · 2 comments
Closed

tomlFormat.generate doesn't chomp tab indentation #8874

Kreyren opened this issue Aug 27, 2023 · 2 comments
Labels

Comments

@Kreyren
Copy link

Kreyren commented Aug 27, 2023

Transferred from NixOS/nixpkgs#251823 as instructed on matrix due to GitHub's issue transfering not working correctly


Describe the bug

Issues observed in home-manager's program.starship.settings.format as described in nix-community/home-manager#4382

Steps To Reproduce

Declare tomlFormat.generate with 2nd argument that is using tabs for indentation parsed through '' string as shown in linked issue.

Expected behavior

Work without issues on tab indentation

Screenshots

image

Additional context

Affected line:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/pkgs-lib/formats.nix#L198

Discussed on matrix: https://matrix.to/#/!KqkRjyTEzAGRiZFBYT:nixos.org/$n1AQxqYcMCHglb15MfUxujcN9tISVsPvzGStK2L0Ciw?via=nixos.org&via=matrix.org&via=tchncs.de

Notify maintainers

Unsure who to notify, triage

Metadata

$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.4.8-xanmod1, NixOS, 23.05 (Stoat), 23.05.2775.720e61ed8de1`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.5`
 - channels(root): `"nixos-23.05, nixos-unstable"`
 - channels(raptor): `"home-manager-23.05.tar.gz, nixpkgs-23.05, nixpkgs-unstable"`
 - nixpkgs: `/home/raptor/.nix-defexpr/channels/nixpkgs`
@Kreyren Kreyren added the bug label Aug 27, 2023
@infinisil
Copy link
Member

Duplicate of #3759 or #2911

@roberth
Copy link
Member

roberth commented Sep 3, 2023

Unfortunately we're stuck with this behavior, it is actionable as discussed by the team, to introduce warnings for this, or move RFC 137 forward.

Closing as duplicate.

@roberth roberth closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants