From fbf3eb203c9b0246a72b72c39adf383b3524f780 Mon Sep 17 00:00:00 2001 From: Malvoz <26493779+Malvoz@users.noreply.github.com> Date: Wed, 19 May 2021 19:22:19 +0200 Subject: [PATCH 1/2] Set inner `role="document"` in popups --- src/mapml/layers/MapLayer.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mapml/layers/MapLayer.js b/src/mapml/layers/MapLayer.js index 2cd89a976..67b27abaf 100644 --- a/src/mapml/layers/MapLayer.js +++ b/src/mapml/layers/MapLayer.js @@ -1184,6 +1184,7 @@ export var MapMLLayer = L.Layer.extend({ popup._container.setAttribute("role", "dialog"); content.setAttribute("tabindex", "-1"); + content.setAttribute("role", "document"); popup._count = 0; // used for feature pagination if(popup._source._eventParents){ // check if the popup is for a feature or query From 97ebd3846f2e868e4e2791812c1576ab4df845a4 Mon Sep 17 00:00:00 2001 From: Malvoz <26493779+Malvoz@users.noreply.github.com> Date: Wed, 19 May 2021 19:25:24 +0200 Subject: [PATCH 2/2] Add link to GH issue in comment on why `role="document"` is needed --- src/mapml/layers/MapLayer.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mapml/layers/MapLayer.js b/src/mapml/layers/MapLayer.js index 67b27abaf..b30f70ea6 100644 --- a/src/mapml/layers/MapLayer.js +++ b/src/mapml/layers/MapLayer.js @@ -1184,6 +1184,7 @@ export var MapMLLayer = L.Layer.extend({ popup._container.setAttribute("role", "dialog"); content.setAttribute("tabindex", "-1"); + // https://github.com/Maps4HTML/Web-Map-Custom-Element/pull/467#issuecomment-844307818 content.setAttribute("role", "document"); popup._count = 0; // used for feature pagination