Rollup merge of rust-lang#24212 - alexcrichton:destabilize-begin-unwind, r=huonw

 Now that we have a `#[allow_internal_unstable]` attribute for macros there's no
need for these two `begin_unwind` functions to be stable. Right now the `panic!`
interface is the only one we wish to stabilize, so remove the stability markers
from these functions.

While this is a breaking change, it is highly unlikely to break any actual code.
It is recommended to use the `panic!` macro instead if it breaks explicit calls
into `std::rt`.

[breaking-change]
cc rust-lang#24208

Author: Manishearth

src/libstd/macros.rs

@@ -37,6 +37,7 @@
 /// ```
 #[macro_export]
 #[stable(feature = "rust1", since = "1.0.0")]
+#[allow_internal_unstable]
 macro_rules! panic {
     () => ({
         panic!("explicit panic")

src/libstd/rt/unwind.rs

@@ -495,7 +495,6 @@ pub extern fn rust_begin_unwind(msg: fmt::Arguments,
 /// on (e.g.) the inlining of other functions as possible), by moving
 /// the actual formatting into this shared place.
 #[inline(never)] #[cold]
-#[stable(since = "1.0.0", feature = "rust1")]
 pub fn begin_unwind_fmt(msg: fmt::Arguments, file_line: &(&'static str, usize)) -> ! {
     use fmt::Write;
 
@@ -511,7 +510,6 @@ pub fn begin_unwind_fmt(msg: fmt::Arguments, file_line: &(&'static str, usize))
 
 /// This is the entry point of unwinding for panic!() and assert!().
 #[inline(never)] #[cold] // avoid code bloat at the call sites as much as possible
-#[stable(since = "1.0.0", feature = "rust1")]
 pub fn begin_unwind<M: Any + Send>(msg: M, file_line: &(&'static str, usize)) -> ! {
     // Note that this should be the only allocation performed in this code path.
     // Currently this means that panic!() on OOM will invoke this code path,
@@ -598,7 +596,6 @@ fn begin_unwind_inner(msg: Box<Any + Send>,
 /// Only a limited number of callbacks can be registered, and this function
 /// returns whether the callback was successfully registered or not. It is not
 /// currently possible to unregister a callback once it has been registered.
-#[unstable(feature = "std_misc")]
 pub unsafe fn register(f: Callback) -> bool {
     match CALLBACK_CNT.fetch_add(1, Ordering::SeqCst) {
         // The invocation code has knowledge of this window where the count has

src/test/run-pass-fulldeps/rename-directory.rs

@@ -12,7 +12,6 @@
 // because it needs TempDir, which is in extra
 
 // ignore-android
-// pretty-expanded FIXME #23616
 
 #![feature(rustc_private, path_ext)]
 

src/test/run-pass/argument-passing.rs

@@ -9,7 +9,6 @@
 // except according to those terms.
 
 
-// pretty-expanded FIXME #23616
 
 struct X {
     x: isize

src/test/run-pass/arith-2.rs

@@ -10,7 +10,6 @@
 
 
 
-// pretty-expanded FIXME #23616
 
 pub fn main() {
     let i32_c: isize = 0x10101010;

src/test/run-pass/arith-unsigned.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![allow(type_limits)]
 

src/test/run-pass/artificial-block.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 fn f() -> isize { { return 3; } }
 

src/test/run-pass/as-precedence.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 fn main() {
     assert_eq!(3 as usize * 3, 9);

src/test/run-pass/asm-in-out-operand.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![feature(asm)]
 

src/test/run-pass/asm-out-assign.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![feature(asm)]
 

src/test/run-pass/assign-assign.rs

@@ -9,7 +9,6 @@
 // except according to those terms.
 
 // Issue 483 - Assignment expressions result in nil
-// pretty-expanded FIXME #23616
 
 fn test_assign() {
     let mut x: isize;

src/test/run-pass/assignability-trait.rs

@@ -12,7 +12,6 @@
 // making method calls, but only if there aren't any matches without
 // it.
 
-// pretty-expanded FIXME #23616
 
 #![feature(unboxed_closures)]
 

src/test/run-pass/associated-types-basic.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![feature(core)]
 

src/test/run-pass/associated-types-binding-in-trait.rs

@@ -11,7 +11,6 @@
 // Test a case where the associated type binding (to `bool`, in this
 // case) is derived from the trait definition. Issue #21636.
 
-// pretty-expanded FIXME #23616
 
 use std::vec;
 

src/test/run-pass/associated-types-bound.rs

@@ -10,7 +10,6 @@
 
 // Test equality constrai32s on associated types in a where clause.
 
-// pretty-expanded FIXME #23616
 
 pub trait ToI32 {
     fn to_i32(&self) -> i32;

src/test/run-pass/associated-types-constant-type.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 trait SignedUnsigned {
     type Opposite;

src/test/run-pass/associated-types-doubleendediterator-object.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![allow(unknown_features)]
 #![feature(box_syntax)]

src/test/run-pass/associated-types-enum-field-named.rs

@@ -10,7 +10,6 @@
 
 // Test associated types appearing in struct-like enum variants.
 
-// pretty-expanded FIXME #23616
 
 use self::VarValue::*;
 

src/test/run-pass/associated-types-enum-field-numbered.rs

@@ -10,7 +10,6 @@
 
 // Test associated types appearing in tuple-like enum variants.
 
-// pretty-expanded FIXME #23616
 
 use self::VarValue::*;
 

src/test/run-pass/associated-types-in-default-method.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 trait Get {
     type Value;

src/test/run-pass/associated-types-in-fn.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 trait Get {
     type Value;

src/test/run-pass/associated-types-in-impl-generics.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 trait Get {
     type Value;

src/test/run-pass/associated-types-in-inherent-method.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 trait Get {
     type Value;

src/test/run-pass/associated-types-issue-20220.rs

@@ -10,7 +10,6 @@
 
 // Test references to `Self::Item` in the trait. Issue #20220.
 
-// pretty-expanded FIXME #23616
 
 use std::vec;
 

src/test/run-pass/associated-types-issue-21212.rs

@@ -13,7 +13,6 @@
 // where clauses in the environment which in turn required normalizing
 // `Self::Input`.
 
-// pretty-expanded FIXME #23616
 
 pub trait Parser {
     type Input;

src/test/run-pass/associated-types-iterator-binding.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 fn pairwise_sub<T:DoubleEndedIterator<Item=isize>>(mut t: T) -> isize {
     let mut result = 0;

src/test/run-pass/associated-types-project-from-type-param-via-bound-in-where-clause.rs

@@ -12,7 +12,6 @@
 // `Item` originates in a where-clause, not the declaration of
 // `T`. Issue #20300.
 
-// pretty-expanded FIXME #23616
 
 #![feature(core)]
 

src/test/run-pass/associated-types-projection-from-known-type-in-impl.rs

@@ -10,7 +10,6 @@
 
 // Test where the impl self type uses a projection from a constant type.
 
-// pretty-expanded FIXME #23616
 
 trait Int
 {

src/test/run-pass/associated-types-projection-in-supertrait.rs

@@ -11,7 +11,6 @@
 // Test that we are handle to correctly handle a projection type
 // that appears in a supertrait bound. Issue #20559.
 
-// pretty-expanded FIXME #23616
 
 trait A
 {

src/test/run-pass/associated-types-ref-in-struct-literal.rs

@@ -10,7 +10,6 @@
 
 // Test associated type references in a struct literal. Issue #20535.
 
-// pretty-expanded FIXME #23616
 
 pub trait Foo {
     type Bar;

src/test/run-pass/associated-types-return.rs

@@ -10,7 +10,6 @@
 
 // Test equality constraints on associated types in a where clause.
 
-// pretty-expanded FIXME #23616
 
 pub trait Foo {
     type A;

src/test/run-pass/associated-types-simple.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 trait Get {
     type Value;

src/test/run-pass/associated-types-stream.rs

@@ -11,7 +11,6 @@
 // Test references to the trait `Stream` in the bounds for associated
 // types defined on `Stream`. Issue #20551.
 
-// pretty-expanded FIXME #23616
 
 trait Stream {
     type Car;

src/test/run-pass/associated-types-struct-field-named.rs

@@ -11,7 +11,6 @@
 // Test that we correctly normalize the type of a struct field
 // which has an associated type.
 
-// pretty-expanded FIXME #23616
 
 pub trait UnifyKey {
     type Value;

src/test/run-pass/associated-types-struct-field-numbered.rs

@@ -11,7 +11,6 @@
 // Test that we correctly normalize the type of a struct field
 // which has an associated type.
 
-// pretty-expanded FIXME #23616
 
 pub trait UnifyKey {
     type Value;

src/test/run-pass/associated-types-sugar-path.rs

@@ -10,7 +10,6 @@
 
 // Test paths to associated types using the type-parameter-only sugar.
 
-// pretty-expanded FIXME #23616
 
 pub trait Foo {
     type A;

src/test/run-pass/attr-main-2.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![feature(main)]
 

src/test/run-pass/attr-no-drop-flag-size.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![feature(unsafe_destructor)]
 #![feature(unsafe_no_drop_flag)]

src/test/run-pass/auto-loop.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 pub fn main() {
     let mut sum = 0;

src/test/run-pass/auto-ref-sliceable.rs

@@ -9,7 +9,6 @@
 // except according to those terms.
 
 
-// pretty-expanded FIXME #23616
 
 trait Pushable<T> {
     fn push_val(&mut self, t: T);

src/test/run-pass/autobind.rs

@@ -9,7 +9,6 @@
 // except according to those terms.
 
 
-// pretty-expanded FIXME #23616
 
 fn f<T>(x: Vec<T>) -> T { return x.into_iter().next().unwrap(); }
 

src/test/run-pass/autoderef-method-on-trait.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![allow(unknown_features)]
 #![feature(box_syntax)]

src/test/run-pass/autoderef-method-priority.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![allow(unknown_features)]
 #![feature(box_syntax)]

src/test/run-pass/autoderef-method-twice-but-not-thrice.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![allow(unknown_features)]
 #![feature(box_syntax)]

src/test/run-pass/autoderef-method-twice.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![allow(unknown_features)]
 #![feature(box_syntax)]

src/test/run-pass/autoderef-method.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![allow(unknown_features)]
 #![feature(box_syntax)]

src/test/run-pass/autoref-intermediate-types-issue-3585.rs

@@ -9,7 +9,6 @@
 // except according to those terms.
 
 
-// pretty-expanded FIXME #23616
 
 #![allow(unknown_features)]
 #![feature(box_syntax)]

src/test/run-pass/big-literals.rs

@@ -8,7 +8,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-// pretty-expanded FIXME #23616
 
 #![feature(core)]