Skip to content

Cython modules should be renamed to have leading underscore #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
diptorupd opened this issue Sep 18, 2020 · 2 comments
Closed

Cython modules should be renamed to have leading underscore #38

diptorupd opened this issue Sep 18, 2020 · 2 comments
Assignees
@diptorupd
Labels
good first issue Good for newcomers
Milestone
gold

Comments

@diptorupd
Copy link
Contributor

e.g. sycl_core.pyx to _sycl_core.pyx
@diptorupd diptorupd self-assigned this Sep 18, 2020
@PokhodenkoSA PokhodenkoSA mentioned this issue Sep 18, 2020
Merged
@diptorupd diptorupd mentioned this issue Oct 9, 2020
Closed
@PokhodenkoSA PokhodenkoSA mentioned this issue Oct 19, 2020
Closed
32 tasks
@PokhodenkoSA
Copy link
Contributor

As I remember common names style could allow using * for point to all cython modules in setup.py instead of list each Cython module.

@diptorupd
Copy link
Contributor Author

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diptorupd diptorupd

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
gold
Development

Successfully merging a pull request may close this issue.

Rename all pxd and pyx filenames to start with _ diptorupd/dpctl
2 participants
@PokhodenkoSA @diptorupd