Merge pull request #1393 from IntelPython/fix-typo-in-sqrt

oleksandr-pavlyk · web-flow · commit a91fc554c345 · 2023-09-06T14:58:58.000-05:00
Fixed constexpr significant bits value for double
diff --git a/dpctl/tensor/libtensor/include/kernels/elementwise_functions/sqrt.hpp b/dpctl/tensor/libtensor/include/kernels/elementwise_functions/sqrt.hpp
@@ -150,11 +150,11 @@ template <typename argT, typename resT> struct SqrtFunctor
 
     int get_normal_scale_double(const double &v) const
     {
-        constexpr int float_significant_bits = 53;
+        constexpr int double_significant_bits = 52;
         constexpr std::uint64_t exponent_mask = 0x7ff;
         constexpr int exponent_bias = 1023;
         const int scale = static_cast<int>(
-            (sycl::bit_cast<std::uint64_t>(v) >> float_significant_bits) &
+            (sycl::bit_cast<std::uint64_t>(v) >> double_significant_bits) &
             exponent_mask);
         return scale - exponent_bias;
     }

Original file line number	Diff line number	Diff line change
`@@ -150,11 +150,11 @@ template <typename argT, typename resT> struct SqrtFunctor`
`150`	`150`
`151`	`151`	`int get_normal_scale_double(const double &v) const`
`152`	`152`	`{`
`153`		`- constexpr int float_significant_bits = 53;`
	`153`	`+ constexpr int double_significant_bits = 52;`
`154`	`154`	`constexpr std::uint64_t exponent_mask = 0x7ff;`
`155`	`155`	`constexpr int exponent_bias = 1023;`
`156`	`156`	`const int scale = static_cast<int>(`
`157`		`- (sycl::bit_cast<std::uint64_t>(v) >> float_significant_bits) &`
	`157`	`+ (sycl::bit_cast<std::uint64_t>(v) >> double_significant_bits) &`
`158`	`158`	`exponent_mask);`
`159`	`159`	`return scale - exponent_bias;`
`160`	`160`	`}`