SyclDevice performs validation when copying from _SyclDevice

Author: oleksandr-pavlyk

dpctl/_sycl_device.pxd

@@ -51,7 +51,7 @@ cdef class SyclDevice(_SyclDevice):
     cdef SyclDevice _create(DPCTLSyclDeviceRef dref)
     @staticmethod
     cdef void _init_helper(SyclDevice device, DPCTLSyclDeviceRef DRef)
-    cdef void _init_from__SyclDevice(self, _SyclDevice other)
+    cdef int _init_from__SyclDevice(self, _SyclDevice other)
     cdef int _init_from_selector(self, DPCTLSyclDeviceSelectorRef DSRef)
     cdef DPCTLSyclDeviceRef get_device_ref(self)
     cpdef get_backend(self)

dpctl/_sycl_device.pyx

@@ -138,8 +138,10 @@ cdef class SyclDevice(_SyclDevice):
         SyclDevice._init_helper(ret, dref)
         return SyclDevice(ret)
 
-    cdef void _init_from__SyclDevice(self, _SyclDevice other):
+    cdef int _init_from__SyclDevice(self, _SyclDevice other):
         self._device_ref = DPCTLDevice_Copy(other._device_ref)
+        if (self._device_ref is NULL):
+            return -1
         self._device_name = DPCTLDevice_GetName(self._device_ref)
         self._driver_version = DPCTLDevice_GetDriverInfo(self._device_ref)
         self._max_compute_units = other._max_compute_units
@@ -183,15 +185,20 @@ cdef class SyclDevice(_SyclDevice):
             string = bytes(<unicode>unicode(arg), "utf-8")
             filter_c_str = string
             DSRef = DPCTLFilterSelector_Create(filter_c_str)
+            ret = self._init_from_selector(DSRef)
             if ret == -1:
                 raise ValueError("Could not create a Device with the selector")
             # Free up the device selector
             DPCTLDeviceSelector_Delete(DSRef)
         elif isinstance(arg, _SyclDevice):
-            self._init_from__SyclDevice(arg)
+            ret = self._init_from__SyclDevice(arg)
+            if ret == -1:
+                raise ValueError("Could not create a Device from _SyclDevice instance")
         elif arg is None:
             DSRef = DPCTLDefaultSelector_Create()
-            self._init_from_selector(DSRef)
+            ret = self._init_from_selector(DSRef)
+            if ret == -1:
+                raise ValueError("Could not create a Device from default selector")
         else:
             raise ValueError(
                 "Invalid argument. Argument should be a str object specifying "