Skip to content

Commit 0601023

Browse files
Ganesh Ajjanagaddemichaelni
Ganesh Ajjanagadde
authored andcommitted
configure: do not fork off grep subprocess in probe_cc
grep is not required for the functionality in this instance. This avoids an unnecessary fork, and also avoids a duplicated dumpversion call. Furthermore, it also corrects behavior when no minor version number is present, see e.g nodejs/node-v0.x-archive#25671. Signed-off-by: Ganesh Ajjanagadde <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
1 parent fa9af30 commit 0601023

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

configure

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3566,9 +3566,9 @@ probe_cc(){
35663566
gcc_pkg_ver=$(expr "$gcc_version" : '[^ ]* \(([^)]*)\)')
35673567
gcc_ext_ver=$(expr "$gcc_version" : ".*$gcc_pkg_ver $gcc_basever \\(.*\\)")
35683568
_ident=$(cleanws "gcc $gcc_basever $gcc_pkg_ver $gcc_ext_ver")
3569-
if ! $_cc -dumpversion | grep -q '^2\.'; then
3570-
_depflags='-MMD -MF $(@:.o=.d) -MT $@'
3571-
fi
3569+
case $gcc_basever in
3570+
2*) _depflags='-MMD -MF $(@:.o=.d) -MT $@' ;;
3571+
esac
35723572
_cflags_speed='-O3'
35733573
_cflags_size='-Os'
35743574
elif $_cc --version 2>/dev/null | grep -q ^icc; then

0 commit comments

Comments
 (0)