Skip to content

Commit be53ded

Browse files
committed
chore: update outdated TODOs as they moved to flutter#8079
Signed-off-by: Ellet <[email protected]>
1 parent c733b44 commit be53ded

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

packages/image_picker/image_picker_macos/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ have them as files on their desktop. The macOS Photos app supports importing ima
3434
`ImageSource.camera` is not supported unless a `cameraDelegate` is set.
3535

3636
### pickImage()
37-
<!-- TODO(EchoEllet): It's possible to support those on file_selector implementation using the same platform API, should we support resizing and compressing for file_selector implementation? Will return new temp file path. -->
38-
The arguments `maxWidth`, `maxHeight`, `imageQuality` and `limit` are only supported when using the [PHPicker](#phpicker) implementation; they are not available in the default [file_selector][5] implementation.
37+
The arguments `maxWidth`, `maxHeight`, `imageQuality`, and `limit` are only supported when using the [PHPicker](#phpicker) implementation; they are not available in the default [file_selector][5] implementation.
3938

4039
The argument `requestFullMetadata` is unsupported on macOS.
4140

packages/image_picker/image_picker_macos/lib/image_picker_macos.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ class ImagePickerMacOS extends CameraDelegatingImagePickerPlatform {
4747
/// Supports picking an image, multi-image, video, media, and multiple media.
4848
bool useMacOSPHPicker = false;
4949

50-
// TODO(EchoEllet): shouldUsePHPicker() and supportsPHPicker() should not be public, avoid using @visibleForTesting
50+
// TODO(EchoEllet): avoid using @visibleForTesting per https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#avoid-using-visiblefortesting
5151

5252
/// Return `true` if the current macOS version supports [useMacOSPHPicker].
5353
///

packages/image_picker/image_picker_macos/macos/image_picker_macos/Sources/image_picker_macos/ImagePickerImpl.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ extension NSItemProvider {
327327
/// - Returns: The image file type (`png` or `jpeg`).
328328
func imageFileType(quality: Int64?) -> NSBitmapImageRep.FileType {
329329
let shouldCompress = shouldCompressImage(quality: quality)
330-
// TODO(EchoEllet): The picked image can be JPEG even if it can represented as a PNG
330+
// TODO(EchoEllet): The picked image can be JPEG even if it can represented as a PNG, should we always store as PNG in case quality is 100 but the image itself is JPEG or other type?
331331
return shouldCompress ? NSBitmapImageRep.FileType.jpeg : NSBitmapImageRep.FileType.png
332332
}
333333

packages/image_picker/image_picker_macos/test/image_picker_macos_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,6 @@ void main() {
529529
},
530530
);
531531

532-
// TODO(EchoEllet): Improve the test names for this and all related in this file
533532
test(
534533
'getVideo uses file selector when PHPicker is disabled',
535534
() async {

0 commit comments

Comments
 (0)