Skip to content

Support Superstruct #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shellscape opened this issue May 15, 2023 · 5 comments
Closed

Support Superstruct #367

shellscape opened this issue May 15, 2023 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@shellscape
Copy link

Please consider supporting superstruct https://docs.superstructjs.org/

It's smaller, more performant, and equally as capable as yup and zod. It just never got picked up by the tech influencers on Twitter so didn't get the popularity boost.

@github-actions github-actions bot added the good first issue Good for newcomers label May 15, 2023
@Code-Hex Code-Hex added the help wanted Extra attention is needed label May 27, 2023
@Code-Hex
Copy link
Owner

Code-Hex commented May 27, 2023

@shellscape I checked superstruct GitHub repository but It looked like it hadn't been updated for a long time.

https://github.com/ianstormtaylor/superstruct

So I don't have the motivation to integrate it into this repository. However, contributions to this repository are welcome!

Ref: #25

@shellscape
Copy link
Author

Come again? It's stable. Stable packages don't need frequent updates, because they're stable.

@Code-Hex
Copy link
Owner

@shellscape I'm looking forward your contribution to add this!

@shellscape
Copy link
Author

I greatly dislike passive aggressiveness, and don't feel it has any place in open source. rather than addressing and discussing the points you raised and my rebuttal, you've deflected. that's a bad signal. appreciate what you've put together here but I'll likely fork rather than contributing back given the responses in this issue.

@Code-Hex
Copy link
Owner

Code-Hex commented May 28, 2023

@shellscape I explained why I have no motivation to write code for this. However, I explained that it is acceptable for you to write and send PR to the repository instead, showing past links as example. It shows that if you contribute, I will also advise on it.

I don't understand the reason for the criticism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants