Skip to content

Upgrade to support Yup 1.0.0 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dml0031 opened this issue Feb 15, 2023 · 0 comments · Fixed by #351
Closed

Upgrade to support Yup 1.0.0 #306

dml0031 opened this issue Feb 15, 2023 · 0 comments · Fixed by #351
Labels
good first issue Good for newcomers

Comments

@dml0031
Copy link

dml0031 commented Feb 15, 2023 •
edited
Loading

There are a couple of breaking changes that seem to break validation generation.

Ex. SchemaOf no longer exists and has been migrated to ObjectSchema.
Ref: https://github.com/jquense/yup/releases/tag/v1.0.0-alpha.3

In addition, the mixed type now requires a Type definition in order to be used with the new ObjectSchema.
Ex:
yup.lazy(() => yup.mixed()) as never => yup.lazy(() => yup.mixed<T>())
@github-actions github-actions bot added the good first issue Good for newcomers label Feb 15, 2023
@Code-Hex Code-Hex mentioned this issue Apr 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade yup v1 Code-Hex/graphql-codegen-typescript-validation-schema
1 participant
@dml0031