Skip to content

asinit produces invalid package.json dependencies #1357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RReverser opened this issue Jun 26, 2020 · 3 comments · Fixed by #1358
Closed

asinit produces invalid package.json dependencies #1357

RReverser opened this issue Jun 26, 2020 · 3 comments · Fixed by #1358

Comments

@RReverser
Copy link

Running npx asinit in an empty folder creates a package.json like following:

{
  "scripts": {
    "asbuild:untouched": "asc assembly/index.ts -b build/untouched.wasm -t build/untouched.wat --sourceMap --debug",
    "asbuild:optimized": "asc assembly/index.ts -b build/optimized.wasm -t build/optimized.wat --sourceMap --optimize",
    "asbuild": "npm run asbuild:untouched && npm run asbuild:optimized",
    "test": "node tests"
  },
  "dependencies": {
    "@assemblyscript/loader": "^0.12.4"
  },
  "devDependencies": {
    "assemblyscript": "^0.12.4"
  }
}

However, it fails at npm install phase, because the latest version of @assemblyscript/loader is only 0.10.1.

@MaxGraey
Copy link
Member

Can confirm.
@dcodeIO will be great also install "@assemblyscript/loader" via asinit by default

@dcodeIO
Copy link
Member

dcodeIO commented Jun 26, 2020

Turns out that the switch to semantic-release didn't cover publishing the loader, so it hasn't been published since then. The PR above should fix this.

In the meantime, requiring assemblyscript/lib/loader instead of @assemblyscript/loader does work as well, but isn't a standalone package. Once the above PR is merged, the next release should include the loader again. 0 UTC.

@dcodeIO
Copy link
Member

dcodeIO commented Jun 27, 2020

The loader has been published again meanwhile. Version 0.12.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants