Skip to content

Commit 127aa8c

Browse files
committed
Don't be lazy when testing experimental features in CI
The diff in #2720 showed that the fixtures for the bindings/raw and bindings/esm tests are out of date. The reason why this is so and why CI didn't complain is the same: these tests are almost always skipped. It also seems like the list of features in ASC_FEATURES is out of date as well, since it doesn't include simd and relaxed-simd. This patch ensures the entire compiler test suite is now run with all features enabled, as I don't think it's reasonable to expect everyone to keep CI in the back of their minds while writing a new test.
1 parent 382aabe commit 127aa8c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/test.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ jobs:
8181
run: npm run build
8282
- name: Test experimental features
8383
env:
84-
ASC_FEATURES: threads,reference-types,gc,exception-handling
84+
ASC_FEATURES: *
8585
run: |
86-
npm run test:compiler features/threads features/reference-types features/gc features/exception-handling
86+
npm run test:compiler
8787
runtimes:
8888
name: "Runtimes"
8989
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)