suppress arduino output

Author: ianfixes

lib/arduino_ci/arduino_cmd.rb

@@ -58,13 +58,13 @@ def prefs
     # @param value [String] the preference value
     # @return [bool] whether the command succeeded
     def set_pref(key, value)
-      success = run_with_gui_guess(" about preferences", "--pref", "#{key}=#{value}", "--save-prefs")
+      resp = run_and_capture(" about preferences", "--pref", "#{key}=#{value}", "--save-prefs")
+      success = resp[:success]
       @prefs_cache[key] = value if success
       success
     end
 
     # run the arduino command
-    # @return [Hash] {:out => StringIO, :err => StringIO }
     def run(*args, **kwargs)
       full_args = [@installation.cmd_path] + args
       @display_mgr.run(*full_args, **kwargs)
@@ -75,7 +75,8 @@ def run_with_gui_guess(message, *args, **kwargs)
       # so, assume that if we don't get a rapid reply that things are not installed
       x3 = @prefs_response_time * 3
       Timeout.timeout(x3) do
-        run(*args, **kwargs)
+        result = run_and_capture(*args, **kwargs)
+        result[:success]
       end
     rescue Timeout::Error
       puts "No response in #{x3} seconds. Assuming graphical modal error message#{message}."
@@ -97,6 +98,9 @@ def run_and_capture(*args)
       { out: str_out, err: str_err, success: success }
     end
 
+    # check whether a board is installed
+    # we do this by just selecting a board.
+    #   the arduino binary will error if unrecognized and do a successful no-op if it's installed
     def board_installed?(boardname)
       run_with_gui_guess(" about board not installed", "--board", boardname)
     end
@@ -105,16 +109,16 @@ def board_installed?(boardname)
     # @param name [String] the board name
     # @return [bool] whether the command succeeded
     def install_board(boardname)
-      run("--install-boards", boardname)
+      run_and_capture("--install-boards", boardname)[:success]
     end
 
     # install a library by name
     # @param name [String] the library name
     # @return [bool] whether the command succeeded
     def install_library(library_name)
-      result = run("--install-library", library_name)
-      @library_is_indexed = true if result
-      result
+      result = run_and_capture("--install-library", library_name)
+      @library_is_indexed = true if result[:success]
+      result[:success]
     end
 
     # update the library index

spec/arduino_cmd_spec.rb

@@ -20,11 +20,15 @@
     arduino_cmd = ArduinoCI::ArduinoCmd.autolocate!
     ArduinoCI::DisplayManager::instance.enable
     it "Finds installed boards" do
-      expect(arduino_cmd.board_installed? "arduino:avr:uno").to be true
+      uno_installed = arduino_cmd.board_installed? "arduino:avr:uno"
+      expect(uno_installed).to be true
+      expect(uno_installed).not_to be nil
     end
 
     it "Doesn't find bogus boards" do
-      expect(arduino_cmd.board_installed? "eggs:milk:wheat").to be false
+      bogus_installed = arduino_cmd.board_installed? "eggs:milk:wheat"
+      expect(bogus_installed).to be false
+      expect(bogus_installed).not_to be nil
     end
   end