Skip to content

An issue with the ruby gems solution #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
feilipu opened this issue Jan 10, 2021 · 6 comments · Fixed by #16
Closed

An issue with the ruby gems solution #15

feilipu opened this issue Jan 10, 2021 · 6 comments · Fixed by #16
Labels
bug Something isn't working

Comments

@feilipu
Copy link

feilipu commented Jan 10, 2021

I've revised the workflow file, and there is a new issue with the ruby gems solution.

Now using Arduino-CI/action@latest.

Not sure if this is transient, or something more important.

Beginning the next phase of testing...           Compilation of example sketches

Discovered example sketch...                          AnalogRead_DigitalRead.ino
Default config, platforms matching architectures in library.properties... 
    uno
    leonardo
    trinket
    gemma
    mega2560
    cplayClassic
...Default config, platforms matching architectures in library.properties       
Board package arduino:avr has a defined URL...                                 ✓
Installing board package arduino:avr...                                        ✓
Board package adafruit:avr has a defined URL...                                ✓
Installing board package adafruit:avr...                                       ✓
bundler: failed to load command: /action/bundle/ruby/2.6.0/bin/arduino_ci.rb (/action/bundle/ruby/2.6.0/bin/arduino_ci.rb)
NoMethodError: undefined method `[]' for nil:NilClass

Originally posted by @feilipu in #11 (comment)

@ianfixes
Copy link
Contributor

Hi feilipu and thanks for opening this. I'm sorry again that you are running into this issue. I'll try to fork your project and see what I can learn by testing it locally.

@ianfixes ianfixes added the bug Something isn't working label Jan 11, 2021
@ianfixes
Copy link
Contributor

I found the issue... a subtle tweak at the last minute to satisfy my style checker introduced a subtle bug.

In the future I will have to break the test script into smaller more testable components, but for now the fix is in the master branch -- which Arduino-CI/action@latest pulls from.

I'll close this when the new released version of the action is available.

@feilipu
Copy link
Author

feilipu commented Jan 14, 2021

I'll note that the blank env: doesn't work.
Was going to note that previously, but... didn't.

The workflow is not valid. .github/workflows/arduino_ci.yml (Line: 13, Col: 13): Unexpected value ''

@ianfixes
Copy link
Contributor

Makes sense. I should add a note that you must delete env: entirely if it's empty. Do you think it would make the documentation more helpful (vs less) if I uncommented some of the default values in there?

@feilipu
Copy link
Author

feilipu commented Jan 14, 2021

Just a note to comment out if not needed is necessary.

@ianfixes
Copy link
Contributor

Sounds good, I've pushed an update to the docs on the master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants