Skip to content

Corpora which store on-disk: permit skipping the generation of .lafl_lock files + duplicates with postfix #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addisoncrump opened this issue Mar 7, 2023 · 3 comments · Fixed by #981
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@addisoncrump
Copy link
Collaborator

addisoncrump commented Mar 7, 2023

In many scenarios, it is not necessary to create/check .lafl_lock nor to duplicate files (in the form <hash>-<number>). We should allow users to disable this functionality.

@addisoncrump addisoncrump added enhancement New feature or request good first issue Good for newcomers labels Mar 7, 2023
@addisoncrump addisoncrump changed the title Corpora which store on-disk: skip the generation of .lafl_lock files + duplicates with postfix Corpora which store on-disk: permit skip the generation of .lafl_lock files + duplicates with postfix Mar 7, 2023
@addisoncrump addisoncrump changed the title Corpora which store on-disk: permit skip the generation of .lafl_lock files + duplicates with postfix Corpora which store on-disk: permit skipping the generation of .lafl_lock files + duplicates with postfix Mar 7, 2023
@bkrl
Copy link

bkrl commented Mar 29, 2023

What would be the best way to add this option to the API? Adding a new argument to the constructors would have to be a breaking change since Rust doesn't have default arguments yet, and adding new constructors doesn't seem to be ideal since there are already three for InMemoryOnDiskCorpus.

@domenukk
Copy link
Member

What would be the best way to add this option to the API? Adding a new argument to the constructors would have to be a breaking change since Rust doesn't have default arguments yet, and adding new constructors doesn't seem to be ideal since there are already three for InMemoryOnDiskCorpus.

Sorry, missed that comment.
It might be useful to add a builder at some point, or simply make it a setting on the corpus after creation

@addisoncrump
Copy link
Collaborator Author

Implemented by #981.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
3 participants