Skip to content

setup.py doesn't specify dependencies correctly #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mje-nz opened this issue Sep 29, 2019 · 0 comments
Closed

setup.py doesn't specify dependencies correctly #70

mje-nz opened this issue Sep 29, 2019 · 0 comments
Milestone

Comments

@mje-nz
Copy link
Contributor

mje-nz commented Sep 29, 2019

Thanks for this package, it's exactly what I've been looking for!

On a fresh Ubuntu install, pip3 install dabest does not install any of the dependencies:

$ sudo apt install python3 python3-pip
# ...
done.
$ pip3 install dabest
Collecting dabest
  Downloading https://files.pythonhosted.org/packages/4b/05/baaf3990f30347f9780977b6b102036b6cbe22a8027e13f331c13e585873/dabest-0.2.5-py2.py3-none-any.whl (61kB)
    100% |################################| 71kB 1.5MB/s 
Installing collected packages: dabest
Successfully installed dabest-0.2.5

If you (unconditionally) specify the dependencies in setup.py then pip will install them automatically. It'd also stop everyone re-reporting the same issues because they have incompatible versions of dependencies (#52, #60, #67).

I'll send you a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants